Bugfix: _energy_ratio handling NaN at the end of EDC #112
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBuechner
requested review from
a team,
ahms5,
artur-pa,
f-brinkmann,
hoyer-a and
mberz
1 task
f-brinkmann
reviewed
Jan 5, 2026
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Thanks for the effort. The code and behavior seems fine to me. I wonder, if and how we should describe this in the docs for already existing parameters. How about adding something like this to the description of the time limit in clarity (and other pull requests):
'If the value exceeds the duration of the EDC or coincides with a NaN-value, it is clipped to the last valid sample of the EDC.'
pyrato/parameters.py
Outdated
Comment on lines
308
to
310
| last_valid_1) | ||
| limits_energy_decay_curve2_idx = np.minimum(limits_energy_decay_curve2_idx, | ||
| last_valid_2) |
Member
There was a problem hiding this comment.
To much indention, I think:
Suggested change
| last_valid_1) | |
| limits_energy_decay_curve2_idx = np.minimum(limits_energy_decay_curve2_idx, | |
| last_valid_2) | |
| last_valid_1) | |
| limits_energy_decay_curve2_idx = np.minimum(limits_energy_decay_curve2_idx, | |
| last_valid_2) |
Author
There was a problem hiding this comment.
I think I would keep it really brief, like you proposed, as this function would only be very rarely used by users without the surrounding energy-parameter function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #111
Changes proposed in this pull request: