Feat/time interval specific decay time #105
Conversation
|
TODO: tests; Please review deeply otherwise 🙏🏻 |
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
Thanks a lot. Looks very professional. For some of my comment I'm not very confident. Please comment you have sth else in mind.
pyrato/edc.py
Outdated
| energy_decay_curve.comment) | ||
|
|
||
|
|
||
| def _edc_linregress(energy_decay_curve: pf.TimeData, t0: float, t1: float): |
There was a problem hiding this comment.
It might be interesting for users to also use this method directly. I would suggest to make it public
pyrato/edc.py
Outdated
| energy_decay_curve.times[t0_idx:t1_idx], | ||
| energy_decay_curve.time[t0_idx:t1_idx]) | ||
|
|
||
| return slope, intercept |
There was a problem hiding this comment.
Im not to familiar with the details, but it might make sence to already return the reverberation_time relative to 60db decay here.
pyrato/edc.py
Outdated
| return slope, intercept | ||
|
|
||
|
|
||
| def early_mid_decay_time(energy_decay_curve: pf.TimeData): |
There was a problem hiding this comment.
I'm not sure if this limits are defined in a Standard or sth similar. Maybe @mberz can claryfiy.
The issue might just provide an example on how this general method could be used. So that the aim could just be to provide the upper method.
ahms5
requested review from
a team,
SimonBuechner,
artur-pa,
f-brinkmann,
hoyer-a and
mberz
and removed request for
a team,
SimonBuechner,
artur-pa,
f-brinkmann and
hoyer-a
ahms5
added
the
ASSA 2025
2 participants
Which issue(s) are closed by this pull request?
Closes #41
Changes proposed in this pull request:
interval_specific_decay_time()inpyrato.parameters