Fix: propagate MessageSendParams.metadata to Worker via TaskSendParams#42
Open
nMaroulis wants to merge 1 commit intopydantic:mainfrom
Open
Fix: propagate MessageSendParams.metadata to Worker via TaskSendParams#42nMaroulis wants to merge 1 commit intopydantic:mainfrom
nMaroulis wants to merge 1 commit intopydantic:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
According to the A2A specification, MessageSendParams includes an optional metadata field intended for extension-specific data:
https://a2a-protocol.org/latest/specification/#711-messagesendparams-object
The
Worker.run_task()method already accepts aTaskSendParamsobject that also defines ametadatafield for this purpose.However, when a message is forwarded to the broker via
TaskManager.send_message(), themetadatafield fromMessageSendParamsis currently dropped and not included in the constructedTaskSendParams.Issue
This prevents Workers from accessing extension metadata that was explicitly provided at the message level, making it impossible to implement certain extensions or advanced workflows that rely on this information.
Change
This PR fixes the issue by forwarding
request['params']['metadata']into thebroker_paramsobject when initializingTaskSendParamsinTaskManager.send_message().Specifically, the following field is now included:
'metadata': request['params'].get('metadata')Impact
Related issue
Fixes: #41