refactor: consume AgentCard in A2AClient#40
Closed
sathvikbhagavan wants to merge 6 commits intopydantic:mainfrom
Closed
refactor: consume AgentCard in A2AClient#40sathvikbhagavan wants to merge 6 commits intopydantic:mainfrom
sathvikbhagavan wants to merge 6 commits intopydantic:mainfrom
Conversation
sathvikbhagavan
changed the title
sathvikbhagavan
force-pushed
the
sb/client_agent_card
branch
from
cf224c3 to
0d6d676
Compare
sathvikbhagavan
force-pushed
the
sb/client_agent_card
branch
from
c9e8150 to
e52d62f
Compare
Author
May I ask why this was closed? This seems like a good change. |
Author
|
I am not sure if the repo is actively maintained. I can revive the PR if that's the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #38
This PR allows
A2AClientto pass url/AgentCardin two ways - one passing a string which can either be a url for the server or url for fetching theAgentCard, other way is to pass theAgentCarditself. Once theAgentCardfetched, url of the server is taken from it.