Add fuzz testing for bloom filter folding#8
Closed
alamb wants to merge 1 commit intopydantic:bloom-filter-foldingfrom
Closed
Add fuzz testing for bloom filter folding#8alamb wants to merge 1 commit intopydantic:bloom-filter-foldingfrom
alamb wants to merge 1 commit intopydantic:bloom-filter-foldingfrom
Conversation
alamb
commented
Apr 1, 2026
| folded.fold_to_target_fpp(target_fpp); | ||
|
|
||
| // Recreate the SBBF with the same block size | ||
| let folded_bytes = folded.0.len() * size_of::<Block>(); |
Author
There was a problem hiding this comment.
I also verified manually that this test covers different size
Testing ndv 5990 target_fpp 0.999, folded 1024 bytes
Testing ndv 19130 target_fpp 0.0001, folded 65536 bytes
Testing ndv 19130 target_fpp 0.001, folded 65536 bytes
Testing ndv 19130 target_fpp 0.1, folded 16384 bytes
Testing ndv 19130 target_fpp 0.2, folded 16384 bytes
Testing ndv 19130 target_fpp 0.9, folded 8192 bytes
Testing ndv 19130 target_fpp 0.99, folded 4096 bytes
Testing ndv 19130 target_fpp 0.999, folded 2048 bytes
Testing ndv 1809 target_fpp 0.0001, folded 8192 bytes
Testing ndv 1809 target_fpp 0.001, folded 4096 bytes
Testing ndv 1809 target_fpp 0.1, folded 2048 bytes
Testing ndv 1809 target_fpp 0.2, folded 2048 bytes
Testing ndv 1809 target_fpp 0.9, folded 512 bytes
Testing ndv 1809 target_fpp 0.99, folded 256 bytes
Testing ndv 1809 target_fpp 0.999, folded 256 bytes
7 tasks
f18709d to
bb6c3a9
Compare
8c3b8e4 to
76bafd2
Compare
Member
|
Just checking, do you want to commit this? We already have a test in the PR that verifies equivalence between a folded filter and an originally smaller filter. |
Author
|
No I don't think we should commit this -- it takes too long. I think it was more of a review exercise for me than anything else. Tanks for checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fuzz test I wrote to prove to myself that the bloom filter auto sizing in the following PR is correct
Right now I think this takes too long to run