feat: add Zeiss CZIReader to microscopy/confocal#175
Open
Sireesiru wants to merge 1 commit intopycroscopy:mainfrom
Open
feat: add Zeiss CZIReader to microscopy/confocal#175Sireesiru wants to merge 1 commit intopycroscopy:mainfrom
Sireesiru wants to merge 1 commit intopycroscopy:mainfrom
Conversation
Contributor
|
Can you please add a test for this reader to this PR? Follow examples such as. Also, current tests are failing, because I believe the class is incorrectly defined in the inits. https://github.com/pycroscopy/SciFiReaders/blob/main/tests/readers/microscopy/spm/afm/test_gwy.py With respect to the inits, do not add CZI reader in this way: all = em.all + spm.all + ['CZIReader'] Rather, you should add it as part of the electron microscopy readers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new CZIReader class within a confocal sub-folder to support Zeiss .czi files. The reader handles multi-channel data and extracts relevant metadata from the CZI XML header