feat: allow explicit location to module#218
Open
tlambert03 wants to merge 1 commit intopybind:mainfrom
Open
Conversation
|
Bump @sizmailov? Seems useful. |
|
At first I was against it, but this seems reasonable enough as virtual environment management in build pipelines can get a bit messy. Suggestion: In the help string for the CLI argument, add an example and/or specify explicitly that it should be the path to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a PR rather than an issue to make it easier to discuss...
In my build pipeline, I would like to be able to provide a specific file location for the module, rather than relying on
import module_name. For example, I'd like to be able to do this:This makes it so that your module doesn't necessarily need to be in a fully qualified and importable location just to be able to create stubs. All other semantics remain the same:
MODULE_NAMErefers to where the module will be importable from, but under the hood, we useimportlib.util.spec_from_file_locationrather thanimportlib.import_module.naturally, very open to feedback :). (also: not immediately sure how to integrate this into the testing setup here)
thanks!