Unify _to_date converter across arrow and polars modules#640
Closed
laughingman7743 wants to merge 2 commits intomasterfrom
Closed
Unify _to_date converter across arrow and polars modules#640laughingman7743 wants to merge 2 commits intomasterfrom
laughingman7743 wants to merge 2 commits intomasterfrom
Conversation
Moved the flexible _to_date function (handling str, datetime, and date) to the base converter module and updated arrow/polars converters to import and reuse it, eliminating duplicate implementations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
laughingman7743
force-pushed
the
master
branch
from
05e7d75 to
0acc69a
Compare
laughingman7743
force-pushed
the
feature/unify-to-date-converter
branch
2 times, most recently
from
ab1ee07 to
8846996
Compare
Added critical rule: never commit directly to master branch, always create feature branches and PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
laughingman7743
force-pushed
the
feature/unify-to-date-converter
branch
from
8846996 to
c3fcdb5
Compare
laughingman7743
force-pushed
the
master
branch
from
0acc69a to
a2d9c20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_to_datefunction (handlingstr,datetime, anddate) to the base converter moduleChanges
pyathena/converter.py: Extended_to_dateto handleUnion[str, datetime, date]pyathena/arrow/converter.py: Removed duplicate_to_date, now imports from basepyathena/polars/converter.py: Removed duplicate_to_date, now imports from baseTest plan
make chkpasses🤖 Generated with Claude Code