fix: Correct version selector to show current version as selected#614
Merged
laughingman7743 merged 1 commit intomasterfrom Oct 18, 2025
Merged
fix: Correct version selector to show current version as selected#614laughingman7743 merged 1 commit intomasterfrom
laughingman7743 merged 1 commit intomasterfrom
Conversation
Fix version selector dropdown to properly select the currently displayed version by comparing version objects instead of comparing version name with current_version string. Changed comparison from `item.name == current_version` to `item == current_version` to properly match the current version object. Now: - v3.12.2 page shows v3.12.2 as selected - master page shows master as selected 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The version selector dropdown was not showing the current version as selected. For example:
v3.12.2/index.html, the dropdown did not have v3.12.2 selectedmaster/index.html, the dropdown did not have master selectedRoot Cause
The template was comparing
item.name == current_version, which compared a string with an object. Thecurrent_versionprovided by sphinx-multiversion is a version object, not a string.Solution
Changed the comparison from
item.name == current_versiontoitem == current_versionto properly compare version objects.Verification
Tested locally:
selectedin dropdownselectedin dropdownChanges
docs/_templates/versioning.htmlto use correct version object comparison🤖 Generated with Claude Code