Fix: Correct engine fixture usage in test_reserved_words#605
Merged
laughingman7743 merged 1 commit intomasterfrom Sep 7, 2025
Merged
Fix: Correct engine fixture usage in test_reserved_words#605laughingman7743 merged 1 commit intomasterfrom
laughingman7743 merged 1 commit intomasterfrom
Conversation
The engine fixture returns a tuple (engine, conn), so we need to unpack it like other tests do. This fixes the CI error where engine.dialect was called on a tuple instead of the engine object. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI failure introduced in #603 where
test_reserved_wordswas callingengine.dialecton a tuple instead of the engine object.Problem
The
enginefixture returns a tuple(engine, conn), but the test was trying to accessengine.dialectdirectly on the tuple, causing:Solution
engine, conn = enginetest_select_offset_limitTest Results
🤖 Generated with Claude Code