Skip to content

surface_test: Expect intended behaviour if SDL2 is new enough #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smcv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

surface_test: Expect intended behaviour if SDL2 is new enough #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sdl2/test/surface_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,13 +467,20 @@ def test_SDL_FreeSurface(self):
sdl2.SDL_FreeSurface(sf)

def test_SDL_GetSetClipRect(self):
# A bug in intersecting empty rectangles was fixed in SDL2 2.33.x
# and in sdl2-compat (which reports its version as >= 2.32.50)
if sdl2.dll.version_tuple >= (2, 32, 50):
true_if_fixed = True
else:
true_if_fixed = None

rectlist = ((rect.SDL_Rect(0, 0, 0, 0), SDL_FALSE, True),
(rect.SDL_Rect(2, 2, 0, 0), SDL_FALSE, False),
(rect.SDL_Rect(2, 2, 0, 0), SDL_FALSE, true_if_fixed),
(rect.SDL_Rect(2, 2, 5, 1), SDL_TRUE, True),
(rect.SDL_Rect(6, 5, 10, 3), SDL_TRUE, False),
(rect.SDL_Rect(0, 0, 10, 10), SDL_TRUE, True),
(rect.SDL_Rect(0, 0, -10, 10), SDL_FALSE, False),
(rect.SDL_Rect(0, 0, -10, -10), SDL_FALSE, False),
(rect.SDL_Rect(0, 0, -10, 10), SDL_FALSE, true_if_fixed),
(rect.SDL_Rect(0, 0, -10, -10), SDL_FALSE, true_if_fixed),
(rect.SDL_Rect(-10, -10, 10, 10), SDL_FALSE, False),
(rect.SDL_Rect(10, -10, 10, 10), SDL_FALSE, False),
(rect.SDL_Rect(10, 10, 10, 10), SDL_TRUE, False)
Expand All @@ -490,7 +497,8 @@ def test_SDL_GetSetClipRect(self):
sdl2.SDL_GetClipRect(sf, byref(clip))
err = "Could not set clip rect %s" % r
assert retval == clipsetval, "retval: " + err
assert (clip == r) == cmpval, "clip: " + err
if cmpval is not None:
assert (clip == r) == cmpval, "clip: " + err
sdl2.SDL_FreeSurface(sf)

def test_SDL_GetSetSurfaceAlphaMod(self):
Expand Down
Loading