Skip to content

fix py13 import bug#1268

Merged
s3alfisc merged 1 commit intomasterfrom
narwhals-py13-bug
Apr 1, 2026
Merged

fix py13 import bug#1268
s3alfisc merged 1 commit intomasterfrom
narwhals-py13-bug

Conversation

@s3alfisc
Copy link
Copy Markdown
Member

@s3alfisc s3alfisc commented Apr 1, 2026

Fix #1263.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core-tests 71.09% <100.00%> (+0.08%) ⬆️
test-r-core 52.69% <100.00%> (+0.08%) ⬆️
test-r-extended 18.89% <100.00%> (+0.14%) ⬆️
test-r-fixest 39.94% <100.00%> (+0.10%) ⬆️
tests-extended ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/FixestMulti_.py 82.10% <100.00%> (+0.09%) ⬆️
pyfixest/estimation/api/feglm.py 90.00% <100.00%> (+0.34%) ⬆️
pyfixest/estimation/api/feols.py 100.00% <100.00%> (ø)
pyfixest/estimation/api/fepois.py 96.15% <100.00%> (+0.15%) ⬆️
pyfixest/estimation/api/quantreg.py 87.23% <100.00%> (+0.27%) ⬆️
pyfixest/estimation/api/utils.py 95.29% <100.00%> (+0.05%) ⬆️
pyfixest/estimation/models/feglm_.py 75.00% <100.00%> (+0.09%) ⬆️
pyfixest/estimation/models/feols_.py 87.18% <100.00%> (-5.03%) ⬇️
pyfixest/estimation/models/feols_compressed_.py 80.35% <100.00%> (+0.11%) ⬆️
pyfixest/estimation/models/fepois_.py 78.54% <100.00%> (+0.09%) ⬆️
... and 2 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@s3alfisc s3alfisc merged commit 6bded96 into master Apr 1, 2026
13 checks passed
@s3alfisc s3alfisc deleted the narwhals-py13-bug branch April 1, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feols Import fails on Python 3.13 -- possible narwhals version issue?

1 participant