Skip to content

Modifying the doc file for IV.#1228

Open
mdizadi wants to merge 9 commits intomasterfrom
iv-doc-development
Open

Modifying the doc file for IV.#1228
mdizadi wants to merge 9 commits intomasterfrom
iv-doc-development

Conversation

@mdizadi
Copy link
Copy Markdown
Collaborator

@mdizadi mdizadi commented Mar 6, 2026

No description provided.

@mdizadi mdizadi marked this pull request as draft March 6, 2026 15:23
@mdizadi mdizadi force-pushed the iv-doc-development branch 2 times, most recently from 44efb91 to 3a72e50 Compare March 6, 2026 16:19
@mdizadi mdizadi force-pushed the iv-doc-development branch from 45aebce to 346f84a Compare March 6, 2026 16:40
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 8.57143% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/utils/dgps.py 8.57% 32 Missing ⚠️
Flag Coverage Δ
core-tests 70.68% <8.57%> (-0.34%) ⬇️
test-r-core 52.35% <8.57%> (-0.24%) ⬇️
test-r-extended 18.70% <8.57%> (-0.06%) ⬇️
test-r-fixest 39.66% <8.57%> (-0.17%) ⬇️
tests-extended ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/__init__.py 81.81% <ø> (ø)
pyfixest/utils/__init__.py 100.00% <ø> (ø)
pyfixest/utils/dgps.py 55.80% <8.57%> (-8.75%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdizadi mdizadi marked this pull request as ready for review March 11, 2026 14:47
@mdizadi mdizadi requested review from apoorvalal and s3alfisc March 11, 2026 15:15
@s3alfisc
Copy link
Copy Markdown
Member

I will take a look over the weekend. Thanks Mo @mdizadi!

- [`Feiv` API Reference](../reference/estimation.models.feiv_.Feiv.qmd) --- full documentation of the IV estimator class.
:::

## Appendix: DGP Design Notes
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep all these dgps in the vignette @mdizadi ? If in doubt, I would rather delete this section?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is only a reference for the reviewer for checking, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants