Open
Conversation
This was
linked to
issues
Mar 6, 2026
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@s3alfisc The core changes to formula parsing are now ready. Feel free to have a look and let me know any comments. I'll continue to work through the to-dos listed above. |
Member
|
Just took a quick look and was thinking - maybe it would be best if we'd do a pair review for this through a call? I would make sure to spent some time with it before to come prepared 😃 |
Collaborator
Author
|
Very happy to jump on a call! |
# Conflicts: # pyfixest/estimation/formula/model_matrix.py # pyfixest/estimation/formula/utils.py
…ics/pyfixest into feat/1213-multipart
When PyCharm launches Python directly (not via pixi run), CONDA_PREFIX is not set. maturin requires it to locate the environment for develop builds. Also add pixi-pycharm to project dependencies. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formulaic'sMULTISTAGEsyntax Implementformulaic's multistage syntax #1125formulaic'sMULTIPARTsyntax Useformulaic'sMULTIPARTsyntax #1213stateful_transformfor fixed effects encoding Implement fixed effects encoding asformulaictransformation #1218To do
^operator is currently reserved for interactions of fixed effects (see here). This is necessary only because the operator expects a number on the right side (e.g.,X^2). We could avoid this if we decided to use a different symbol for fixed effect interactions (e.g.,f1:f2).stateful_transformworks correctly on the captured context (see here and related to Enable formulaic to parse custom data transforms from context #769).predict()method fails with new data and pyfixest special syntax -i(),C(),var1^var2operators #684Y+Y2 ~X1should be replaced withsw(Y, Y2) ~ X1;Y ~ X1 | X2 ~ Z2withY ~ X1 + [X2 ~ Z2])formulaic.formula.Formula.required_variablescallsast.parse(factor.expr, mode="eval")which might fail if variable names are not valid Python expressions (e.g.,0_X2_1). This, however, is necessary to account for transformed variables (e.g.,Y ~ C(X2) + [X2 ~ Z2]).Y ~ [X1 ~ Z1] + [X2 ~ Z2].