Distinguish comma delimiter from thousand separator#38
Open
leostimpfle wants to merge 2 commits intopy-econometrics:mainfrom
Open
Distinguish comma delimiter from thousand separator#38leostimpfle wants to merge 2 commits intopy-econometrics:mainfrom
leostimpfle wants to merge 2 commits intopy-econometrics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34.
The idea is to distinguish a comma delimiter from a format specification by evaluating whether the string including the comma is a valid format mini-language expression. This may not be the most performant (because it calls
_is_valid_format_specfor every comma but keeps explicit string parsing to a minimum.