add streaming OLS implementation with duckdb arrow interop#17
Open
apoorvalal wants to merge 3 commits intomasterfrom
Open
add streaming OLS implementation with duckdb arrow interop#17apoorvalal wants to merge 3 commits intomasterfrom
apoorvalal wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a streaming OLS implementation that leverages DuckDB's Arrow IPC support for memory-efficient regression on large datasets. The implementation uses sufficient statistics to process data in chunks rather than loading everything into memory.
- Adds streaming regression functionality with DuckDB Arrow interop
- Implements sufficient statistics-based OLS and Ridge regression
- Provides comprehensive test coverage for the streaming implementation
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| duckreg/stream.py | Core streaming regression implementation with Arrow IPC support |
| tests/test_stream.py | Test suite covering streaming regression functionality |
| duckreg/init.py | Exposes StreamingRegression in public API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+74
to
+75
| feature_cols: list[str] = None, | ||
| target_col: str = None, |
There was a problem hiding this comment.
Using mutable default arguments (None) should be replaced with proper Optional type annotations and default to None explicitly. The type hints should be Optional[list[str]] and Optional[str].
Suggested change
| feature_cols: list[str] = None, | |
| target_col: str = None, | |
| feature_cols: Optional[list[str]] = None, | |
| target_col: Optional[str] = None, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.