Skip to content

Conversation

@centromere
Copy link
Contributor

Note: Section 3.5.3.1 of the OCFL specification requires that UTC be represented by "Z", not by "+00:00". The unit tests have been updated accordingly.

@pwinckles
Copy link
Owner

@centromere Thanks for the PR. I'll take a look at it when I have a chance, though I don't think I agree with you about the timestamp format.

@centromere
Copy link
Contributor Author

After re-reading the OCFL spec and RFC3339, I believe that the spirit of the law is to allow both representations.

I have not investigated too deeply, but I believe a dependency, after being bumped, is now emitting Z instead of +00:00. I do not yet know which dependency or what would need to be changed to get it to emit +00:00. Given that they are semantically equivalent, it was easier for me to modify the unit tests than to track down why the behavior of the dependency changed.

@pwinckles
Copy link
Owner

@centromere Interestingly, there was a timezone related failure in CI, but it didn't fail for me locally. In the mean time, I tried updating the crusty old github actions and applied all of the clippy fixes. Do you want to rebase your PR, and try again?

Note: Section 3.5.3.1 of the OCFL specification requires that UTC be
represented by "Z", not by "+00:00". The unit tests have been updated
accordingly.
@pwinckles
Copy link
Owner

@centromere Try changing the timestamp in the assert in commit_should_pretty_print_inventory to

timestamp.to_rfc3339_opts(SecondsFormat::Secs, true)

@pwinckles pwinckles merged commit e0a8b2c into pwinckles:main Jan 25, 2026
3 checks passed
@centromere centromere deleted the bump-dependencies branch January 25, 2026 03:26
@centromere
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants