Add option to resize the viewport according to the pw-canvas element so that the maximum viewport size is used.#38
Open
SmokyBot wants to merge 3 commits intopwambach:masterfrom
Open
Add option to resize the viewport according to the pw-canvas element so that the maximum viewport size is used.#38SmokyBot wants to merge 3 commits intopwambach:masterfrom
SmokyBot wants to merge 3 commits intopwambach:masterfrom
Conversation
# Conflicts: # dist/angular-canvas-painter.js # dist/angular-canvas-painter.min.js # js/pwCanvas.js
Author
|
Please do check for code quality though. This is working in my project but should be verified before merging |
SmokyBot
commented
Sep 10, 2023
Author
There was a problem hiding this comment.
This file also needs to compiled again. How do you compile the .min.js?
Author
There was a problem hiding this comment.
I have recompiled the files with gulp :)
…e-generate minified file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usage: in the options add: