Skip to content

Fixing background image size#29

Open
sajan45 wants to merge 1 commit intopwambach:masterfrom
sajan45:patch-1
Open

Fixing background image size#29
sajan45 wants to merge 1 commit intopwambach:masterfrom
sajan45:patch-1

Conversation

@sajan45
Copy link
Copy Markdown

@sajan45 sajan45 commented Aug 23, 2016

This will set the background image height and width to the size of canvas so that it will not show only a part a of the image if the image is bigger in size than canvas.

This will set the background image height and width to the size of canvas so that it will not show only a part a of the image if the image is bigger in size than canvas.
@pwambach
Copy link
Copy Markdown
Owner

Hey, thanks for the PR.
Nice feature, but we should make it configurable in the options object as this is a breaking change. Also not everybody wants the background image to be streched or squeezed.

The option name could be e.g. fitImageToCanvas

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants