Skip to content

Conversation

@pvogt09
Copy link
Owner

@pvogt09 pvogt09 commented Aug 4, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the LGPL 3 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits.
This repository enforces the DCO.


What does this PR aim to accomplish?:
Add ability to compile tikz pictures in pull requests.

How does this PR accomplish the above?:
Adds action step and script to compile tikz pictures.

What documentation changes (if any) are needed to support this PR?:
None.

pvogt09 added 4 commits August 4, 2020 15:38
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
@github-actions github-actions bot added Feature:CI Functionality related to CI/CD Feature:Documentation Improvements or additions to documentation labels Aug 4, 2020
pvogt09 added 9 commits August 4, 2020 14:09
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
@pvogt09
Copy link
Owner Author

pvogt09 commented Aug 4, 2020

Does not work correctly because:

  • Job does not exit with failure when compilation of tikz pictures fails.
  • Produced pdf files can not be found by convert.
  • Job should only run for the changed images and not all.
  • Metadata like creation dates should optionally be removes from the pictures to make them comparable.

@pvogt09 pvogt09 marked this pull request as draft August 5, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:CI Functionality related to CI/CD Feature:Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants