Use type-only import for better verbatimModuleSyntax support #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakyadam
suggested changes
Nov 6, 2024
lakyadam
left a comment
lakyadam
left a comment
There was a problem hiding this comment.
It looks like typescript doesn't like this syntax.
This changing it to individual type imports like this:
import React, { type ReactHTML, type ReactSVG, type ReactNode, type ComponentType } from "react";
lakyadam
approved these changes
Dec 12, 2024
lakyadam
left a comment
lakyadam
left a comment
There was a problem hiding this comment.
Looks good,. Can we get this merged?
|
|
@pveyes any chance you could take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have this weird TypeScript issue where—even though I have excluded
node_modulesin mytsconfig.json—I get a type error from "htmr" when usingtsc.I'm using
verbatimModuleSyntax(documentation) to simplify import elision. The setting comes down to ensuring you use thetypemodifier when importing types. So I did that insrc/types.ts.I don't think it'd have any negative impact since
yarn typecheckran successfully. But feel free to let me know otherwise.Thanks for considering!