feature/946 Setup cancancan #965
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevio18324
changed the title
3 tasks
Collaborator
Author
nevio18324
force-pushed
the
feature/946-setup-cancancan
branch
from
4699d7b to
7bd4607
Compare
ManuelMoeri
requested changes
Jul 22, 2025
Collaborator
ManuelMoeri
left a comment
ManuelMoeri
left a comment
There was a problem hiding this comment.
Looks good. Only found two small things.
ManuelMoeri
force-pushed
the
feature/946-setup-cancancan
branch
from
387c0e8 to
0532487
Compare
ManuelMoeri
force-pushed
the
feature/946-setup-cancancan
branch
from
0532487 to
83da19f
Compare
Robin481
requested changes
Jul 31, 2025
3 tasks
nevio18324
force-pushed
the
feature/946-setup-cancancan
branch
from
83da19f to
e17dbd2
Compare
…ble by conf_admins
nevio18324
force-pushed
the
feature/946-setup-cancancan
branch
from
e17dbd2 to
48ebd8e
Compare
Robin481
requested changes
Feb 12, 2026
Member
Robin481
left a comment
Robin481
left a comment
There was a problem hiding this comment.
Looking quite good.
One thing I've noticed is that deletion of inactive profiles via the admin interface does not validate if a person is allowed to do this or not.
Since we don't use the standard CrudController method here:
This method could probably call
super and then do our custom logic and it would work as expected.Can you please have a look at this special case and also comb through the code if you find other places where we don't use the default methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.