Ingame reloading of assets when changing settings#60
Open
LossRain wants to merge 8 commits intopuyonexus:masterfrom
Open
Ingame reloading of assets when changing settings#60LossRain wants to merge 8 commits intopuyonexus:masterfrom
LossRain wants to merge 8 commits intopuyonexus:masterfrom
Conversation
This hopefully gets away with the requirement for the "template" AssetManager class.
I am sorry for this huge commit. It gives the Game object a simple way of reaching (possibly) all of the game assets and reload them upon request. Currently it triggers on the closure of the settings dialogue.
jchv
reviewed
Mar 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to dynamically apply changes of some preferences to existing
Games after closing the Settings dialog in the Client. Additionally separatesAssetManagerinto two classes (a base class and generated helper with access to the game's parameters)AssetBundles are now front-end agnostic and takeppvs::Frontend*as a parameter for required actions.Requires further testing before merging (live changing of preferences for multiple Game instances works, relaunching is fully functional for me, ClientNG works, memory usage and leaks haven't been analyzed)