Draft
Conversation
We want to align ourselves to the standard paths when it comes to User Data, Cache and Configs on most possible platforms. This is partially in an effort to ease mod creation by guaranteeing user access to User Data folders. This commit might need revisioning for completely portable installations. This commit may be breaking and might require intervention by the updater.
Contributor
|
Root level folder is possibly necessary until we have a better auto update strategy. The reason is that directories in Program Files are only writable for admin users. Also, I do agree that we should move towards this, but I'd also like to continue supporting "portable" installations. The method I propose for doing this is allowing there to be a configuration file next to the binary that can override the paths used. That way, the current auto update can ship a file that keeps the game working for them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now we have been largely hard-coding the location of user files for PuyoVS. While this approach is okay it might turn back on us, especially when we account for modding support as we need to make sure that the user has access to the system assets at runtime, because otherwise we will not be able to store cached / permanently downloaded add-ons downloaded from within the game.
This is far from being complete, we need to thoroughly test that these folders are actually readable by the user and that we can go ahead without completely breaking the game and make the updater aware of the changes to prevent additional breakage.
PS: A bit controversial but I believe that on Windows we should just hide our assets in C:\ProgramFiles as creating a root level folder seems extremely odd and bloaty.