Use SupportSQLite instead of the framework version #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inorichi
commented
Nov 23, 2018
| public void insertOne() { | ||
| final User user = putUserBlocking(); | ||
|
|
||
| // why we created StorIOSQLite: nobody loves nulls |
Author
There was a problem hiding this comment.
This comment is now outdated 😅
nikitin-da
reviewed
Nov 25, 2018
| .insertOrThrow( | ||
| .insert( | ||
| insertQuery.table(), | ||
| insertQuery.nullColumnHack(), |
Collaborator
There was a problem hiding this comment.
As SupportSQLiteDatabase doesn't allow nullColumnHack, and we should remove it from InsertQuery too
| public void insertOne() { | ||
| final User user = putUserBlocking(); | ||
|
|
||
| // why we created StorIOSQLite: nobody loves nulls |
nikitin-da
approved these changes
Nov 25, 2018
Collaborator
nikitin-da
left a comment
nikitin-da
left a comment
There was a problem hiding this comment.
Awesome, @inorichi thank you for request!
Collaborator
|
@artem-zinnatullin may we drop old SQLite support in v4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the framework SQLite version with the new SupportSQLite from AndroidX.
This new implementation allows to use more SQL implementations besides the framework one, like the sqlite-android database from requery, which was requested at #662.
All tests are passing and the sample app works, but I don't know if I missed something. Readme should be updated too to reflect the changes required to use the new approach with
FrameworkSQLiteOpenHelperFactory.I guess this PR would be included in a 4.x release 😄