Skip to content

Conversation

@pivotal-ivan-rodriguez
Copy link

Added Carthage support
https://github.com/Carthage/Carthage

@@ -0,0 +1,2 @@
github "tonymillion/Reachability" "master"
github "square/SocketRocket" No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with Carthage but should this dependency be fixed here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pusher-ci
Copy link

@pivotal-ivan-rodriguez: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@pusher-ci
Copy link

@pivotal-ivan-rodriguez: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pusher-ci
Copy link

@pivotal-ivan-rodriguez: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants