Skip to content

fix: node-pty spawn-helper permissions on macOS with pnpm #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-dent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: node-pty spawn-helper permissions on macOS with pnpm #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bridge/src/voice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ function findBinary(candidates: string[], fallback: string): string {

/** Check if a whisper-cli binary has Metal GPU support (native arm64 + libggml-metal). */
function detectMetal(whisperPath: string): boolean {
// Skip if whisper-cli doesn't exist (just a fallback name, not installed)
if (!existsSync(whisperPath)) {
debug('Voice', `whisper-cli not found, skipping Metal detection`);
return false;
}
try {
const otoolOut = execSync(`otool -L "${whisperPath}"`, { encoding: 'utf8' });
const hasMetal = otoolOut.includes('libggml-metal');
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"generate-icons": "node scripts/generate-icons.mjs",
"package": "bash scripts/package-plugin.sh",
"setup": "bash scripts/install.sh",
"test": "vitest run"
"test": "vitest run",
"postinstall": "bash scripts/postinstall.sh"
},
"engines": {
"node": ">=20.0.0"
Expand Down
9 changes: 9 additions & 0 deletions scripts/postinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash
# Fix node-pty spawn-helper permissions (pnpm doesn't preserve execute bits from prebuilds)

find node_modules -path "*node-pty*/prebuilds/darwin-*/spawn-helper" 2>/dev/null | while read -r SPAWN_HELPER; do
if [ -n "$SPAWN_HELPER" ] && [ ! -x "$SPAWN_HELPER" ]; then
chmod +x "$SPAWN_HELPER"
echo "[postinstall] Fixed spawn-helper permissions: $SPAWN_HELPER"
fi
done