FOR REVIEW: proposed file path additions for facter #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the file_paths spec to include proposed locations for new config file and fact cache locations for facter. Follow along at puppetlabs/puppet-rfc
Contributor
|
@Magisus have you taken a look at this? Not sure how the |
Contributor
|
This supports what I have implemented so far. I haven't yet referred to either the cache directory or the config snippets directory in my code. I know in theory HOCON supports including entire other files into a top-level config, but I'm not sure if that has been fully implemented in cpp-hocon yet. This would be a good test case for that functionality. What is an example use case? |
Contributor
|
We've released this. Were there any changes, or is it ready to merge? |
Contributor
|
We do not have support for conf.d yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the file_paths spec to include proposed locations
for new config file and fact cache locations for facter.
Follow along at puppetlabs/puppet-rfc