Update RSAPI spec to match actual implementation #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the Resource API for the `simple_get_filter` feature uses an empty array for the names paramter to signal that all resources should be returned, not `nil`. Instead of changing the code to match the spec, it probably makes more sense to change the spec to match the implementation.
Author
|
After consideration, I think fixing the documentation/specification makes more sense than fixing the code, but if a code fix is preferred please see: puppetlabs/puppet-resource_api#304 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the Resource API for the
simple_get_filterfeature uses an empty array for the names paramter to signal that all resources should be returned, notnil. Instead of changing the code to match the spec, it probably makes more sense to change the spec to match the implementation.