Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Comments

Update www_root empty check#59

Open
kyriog wants to merge 1 commit intopuphpet:masterfrom
kyriog:nginx-undef-www-root
Open

Update www_root empty check#59
kyriog wants to merge 1 commit intopuphpet:masterfrom
kyriog:nginx-undef-www-root

Conversation

@kyriog
Copy link

@kyriog kyriog commented Dec 28, 2018

In nginx puppet manifest used in puphpet, a vhost can be generated without root instruction if the www_root directive isn't set (which, in my case, is useful because the root clause is declared by a including a file using include_files).

The problem: as this manifest check for '' and not undef, the check fails on the if ! defined(File[$vhost['www_root']]) test.

I think PuPHPet website should be updated too to remove www_root directive if the value is empty on configurator, but that's over my knowledge of this project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant