This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Fixes cURL issue and makes wget act identically. #2098#2
Open
shanept wants to merge 1 commit intopuphpet:masterfrom
Open
Fixes cURL issue and makes wget act identically. #2098#2shanept wants to merge 1 commit intopuphpet:masterfrom
shanept wants to merge 1 commit intopuphpet:masterfrom
Conversation
|
Thanks! It is working for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the cURL issue outlined in issue puphpet/puphpet#2098.
The composer installer expects an environment variable "COMPOSER_HOME", which does not exist upon running the composer installer.
There are also two different installation methods, namely curl and wget, which previously operated two very seperate ways. One downloading composer and the other downloading the composer installer, hence the previous remedy for fixing curl was to switch to wget. This has been changed so both wget and curl download the installer, and run as expected.