Add warning diagnostic on duplicate toplevel key #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyeh
force-pushed
the
syeh/duplicate-toplevel-key-warning
branch
from
006f6ec to
65e6226
Compare
seanyeh
commented
Jan 28, 2026
|
|
||
| key := kvp.Key.Value() | ||
|
|
||
| // Add warning diagnostic for duplicate top-level keys |
Contributor
Author
There was a problem hiding this comment.
@pgavlin does adding a warning seem reasonable for duplicate top-level keys?
tehsis
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning diagnostic if there are duplicate toplevel keys