Skip to content

Conversation

@cnunciato
Copy link
Contributor

@cnunciato cnunciato commented Jan 30, 2026

Fixes pulumi/marketing#1597.

@claude
Copy link
Contributor

claude bot commented Jan 30, 2026

Documentation Review

This PR updates the BMW Group logo from a simpler icon to the full corporate logo with text.

Issues Found

1. Incorrect Issue Reference

The PR description references "Fixes #1597", but issue #1597 is about reorganizing generated API docs pages, which is completely unrelated to updating a customer logo. The issue reference should either be removed or corrected to reference the appropriate issue if one exists.

Observations

Files Changed:

  • layouts/partials/customer-logos/bmw.html
  • static/logos/customers/bmw.svg

Both files are being updated with identical SVG content, which appears correct. The new logo:

  • Changes dimensions from 500x241 to 2345x300
  • Updates from a simple BMW roundel to the full "BMW Group" logo with text
  • Maintains proper SVG structure with viewBox, paths, masks, and clip-paths
  • Uses appropriate fill colors (#6F6F6F, #6E6E6E, white, #0066B0)

Technical Review:

  • ✅ Both files end up with identical, valid SVG markup
  • ✅ No accessibility concerns (logos are presentational elements in customer logo grids)
  • ✅ SVG structure is valid
  • ✅ File format is appropriate

Recommendation

Please update the PR description to either:

  1. Remove the "Fixes Reorganize content within generated API docs pages #1597" reference entirely, or
  2. Add a reference to the correct issue if one exists for updating the BMW logo

Otherwise, the technical changes look good.


Mention me (@claude) if you'd like additional reviews or fixes.

@pulumi-bot
Copy link
Collaborator

@cnunciato cnunciato enabled auto-merge (squash) January 31, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants