Skip to content

Conversation

@rgharris
Copy link
Contributor

Detailed diff option was just added and Neo summary was existing.

Closes pulumi/pulumi-cloud-requests#120

Detailed diff option was just added and Neo summary was existing.

Closes pulumi/pulumi-cloud-requests#120
@claude
Copy link
Contributor

claude bot commented Jan 30, 2026

Documentation Review

I've reviewed the image updates for PR #17374. Here are my findings:

What's Working

  • Both images (static/images/docs/github-app/gha-installed.png and static/images/docs/service/gha-installed.png) have been updated to show the new settings interface
  • The images are identical (verified via MD5 hash), which ensures consistency
  • File sizes are reasonable (~90KB each)
  • The images clearly show all three toggle options: Pull Request comments, Neo summaries for Pull Request comments, and Detailed diff for Pull Request comments

Issues Found

1. Missing Documentation for New Features

The updated screenshot shows two settings that are not documented in the GitHub App guide:

File: content/docs/iac/guides/continuous-delivery/github-app.md

  • Neo summaries for Pull Request comments: This feature is shown in the screenshot but not explained in the documentation. Users will see this option in the UI but won't know what it does.
  • Detailed diff for Pull Request comments: This newly added feature (per PR description) is not documented at all.

Recommendation: Add a section after line 63 in content/docs/iac/guides/continuous-delivery/github-app.md explaining these settings.

2. Unused Image Path

File: static/images/docs/service/gha-installed.png

This image is not referenced anywhere in the documentation (searched all .md files). The duplicate may be legacy/deprecated, intended for future use, or used in a different context not found in the markdown files.

Recommendation: Either remove this duplicate file if it's not needed, or document where it should be used.

Summary

The image update is accurate and shows the current UI state, but the documentation needs to be updated to explain the new features shown in the screenshot. This is especially important since you're closing pulumi/pulumi-cloud-requests#120, which likely requested this functionality.

Mention @claude if you'd like me to help add the missing documentation or review any changes.

@pulumi-bot
Copy link
Collaborator

@rgharris rgharris requested a review from a team January 30, 2026 19:34
@rgharris rgharris enabled auto-merge (squash) January 30, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulumi Github app does not show the diff

3 participants