-
Notifications
You must be signed in to change notification settings - Fork 261
Event page template and Kubecon page #17299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Documentation ReviewI've reviewed the event page template system and KubeCon 2026 page implementation. Overall, this is a well-structured templating system with good documentation. Here are my findings: Issues Found1. Missing trailing newline in deleted fileFile:
2. Incorrect file reference in documentationFile:
3. Heading capitalization inconsistenciesFile: Multiple H2 headings use Title Case instead of Sentence case:
According to STYLE-GUIDE.md, H2 and deeper headings should use Sentence case. 4. Redundant "Benefits" sectionsFile:
5. Grammar: Extra space in testimonial attributionFile: author: " — Platform Engineering Team, BMW"
6. Empty title field in testimonialFile: title: ""
7. TBD placeholders in contentFile:
8. Alt text best practice noteFile: Multiple template files
Positive Observations✓ Well-structured, modular template system with clear separation of concerns SummaryThis PR introduces a solid foundation for reusable event pages. The main issues are: Must Fix:
Should Fix:
Consider:
The template system itself is well-designed and the code quality is good. The Hugo templating is clean and the SCSS follows good practices with mixins. Mention @claude if you'd like me to help fix any of these issues or review additional changes. |
|
Your site preview for commit 2afdefc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17299-2afdefce.s3-website.us-west-2.amazonaws.com. |
|
@kimberleyamackenzie Meta Image |
Copy changes
|
@kimberleyamackenzie I was going to leave comments, but then I realized they were all copy changes, so I updated them myself. Design feedback was given to @vctrfrnndz |
@vctrfrnndz did you create it on Figma or Canva? Can you share, as we have some book demo / book meeting landing pages that need an image too, that way they all match. |
|
Your site preview for commit 34d93dd is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17299-34d93ddd.s3-website.us-west-2.amazonaws.com. |
|
@kimberleyamackenzie on the quote, BMW appears twice. I can't tell by looking at the file why it happens.
|
|
Note @kimberleyamackenzie @vctrfrnndz, for event pages, the map is temporary until we have an image that shows where the booth is located in the venue. We currently don't have the booth number, so only that is set will Traci be able to provide the location.
|
Co-authored-by: Sara <100384099+SaraDPH@users.noreply.github.com>
|
Ok! One thing I'm seeing is that the size of the copy (which feels like a touch (~.25-.5rem-ish?) too large overall) and the whitespace are somehow conspiring to push the CTAs too far down on the page. Assuming this'll act as a template for others to follow, we'll definitely need those CTAs to end up higher above the fold. Here's how they look on my MacBook, for example:
Compare to, say, an example from Buildkite, which is closer to where we'll need to be in terms where the elements fall on the page:
If it helps, when I
Thoughts on scaling things down just a notch @vctrfrnndz @kimberleyamackenzie? (I also realize this may conflict with our current theme sizing somewhat relevantly.) |
|
@cnunciato Agreed, some of these adjustments are already reducing the base text. We can tone down more elements like heading text further! |
|
@vctrfrnndz Ok great, thanks! Yeah, overall our current design somewhat suffers from how "big" everything is, so bringing it all down a notch or two should help in many ways I think. Something tells me we might still end up a little too big with those values, but let's see! |
| </div> | ||
| <div class="hidden md:block"> | ||
| {{ if $mapEmbed }} | ||
| <div class="w-full md:max-w-2xl md:h-96"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the actual map-embed (as opposed to static image — more useful = better in my book!), but it'd be great to apply the corner treatments in the design (i.e., the roundings) here as well. Possible, with some border and overflow magic maybe?
Also, little thing, but having a spot for a copyable addresses (even if I have to double-click and paste it into my maps app of choice) is always super useful in this context.
| <div class="flex flex-col sm:flex-row items-start gap-4"> | ||
| <a href="{{ $ctaLink }}" class="btn-primary-template-variant inline-flex items-center gap-2"> | ||
| <span>{{ $ctaText }}</span> | ||
| <span>→</span> | ||
| </a> | ||
| {{ if $ctaSecondaryText }} | ||
| <a href="{{ $ctaSecondaryLink }}" class="btn-secondary-template-variant inline-flex items-center gap-2"> | ||
| <span>{{ $ctaSecondaryText }}</span> | ||
| <span>→</span> | ||
| </a> | ||
| {{ end }} | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Your site preview for commit 37fb07d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17299-37fb07dc.s3-website.us-west-2.amazonaws.com. |
|
Okay, tried some stuff in the latest rev:
|
|
Your site preview for commit 19fd2f0 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17299-19fd2f0d.s3-website.us-west-2.amazonaws.com. |
|
@SaraDPH thanks for the reminder, done! |
|
Your site preview for commit 4b5910d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17299-4b5910dd.s3-website.us-west-2.amazonaws.com. |
|
Thank you @kimberleyamackenzie! It's looking amazing. I'll go through this latest rev tonight and get y'all some feedback for tomorrow. I may make a few copy-only tweaks (sentence-case-ification, etc.) in the meantime — mind if I push a commit with that? |
|
@cnunciato for sure! push any changes you'd like |
|
Ok, more feedback for y'all. 💜
I think that's it for now! 😅 I still have some copy changes to make, but we're close! |
|
Your site preview for commit d66522d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17299-d66522d9.s3-website.us-west-2.amazonaws.com. |
|
@vctrfrnndz @kimberleyamackenzie A few more things I noticed when browsing around on mobile and tablet this morning:
All right, that's it! Pencils down for me. 😇 |
































Create a template for event pages that will be reusable across multiple event pages. This is a starting point - as we see how this fits with future events and requirements, I would expect this will shift a little to become more flexible in some places and more rigid in others. Additionally, right now we have quite a bit of styling in the stylesheet for this template because we're fighting against globally applied styles elsewhere; this should also eventually be chipped away at as we transition more pages to the new/templated style.
Also implements a page using the template for Kubecon Europe 2026.