-
-
Notifications
You must be signed in to change notification settings - Fork 2
Decaffeinate/bump dependency #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decaffeinate/bump dependency #7
Conversation
|
I've gone ahead and merged #6 with your review, so hopefully it's not too much trouble to rework this PR so we can get it merged. Especially exciting to have |
88ed94f to
6fde748
Compare
|
OK, reworked this PR to be more targeted:
|
…now that we've changed major versions.
…to `Buffer.alloc`.
|
Also just added the change described in #1 because it's been open for 2+ years. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was originally hoping to review the spec decafe more closely, but with a quick glance it looks good and tests are still running just fine. As for the changes made in the actual code they look good and are simple enough. I'll go ahead and merge this one.
Although if we are bundling up changes from that other PR, I'll also just go ahead and merge that one then this one so we don't just have to close that out.
EDIT:
Actually realized that other one can't be merged now with our switch to JS. So nvm on that front
Creating this as a draft because it's largely duplicated work and I don't want it to overshadow #6.
The issue reported in pulsar-edit#1236 can only be fixed by upgrading one of
scandal’s dependencies; and I figured if we touchedscandalat all, it would be irresponsible not to decaffeinate it.I should've checked whether a decaffeination was already in progress!
This PR contains my own decaffeination attempt, but also bumps the dependency in question
isbinaryfileto version 3 so that itspackage.jsonwill no longer be malformed, hence will no longer generate error spam in the console.If #6 makes it to
master, this diff will get a lot smaller, and perhaps it'll be easier to reduce it to just the part that matters (the dependency bump). When I can pull that off, I'll take this out of draft.