Skip to content

Redirect all web traffic to packages#141

Merged
confused-Techie merged 2 commits intomainfrom
web-redirect
Sep 2, 2025
Merged

Redirect all web traffic to packages#141
confused-Techie merged 2 commits intomainfrom
web-redirect

Conversation

@confused-Techie
Copy link
Member

With us launching the new subdomain for packages, and those changes being live we now just need to handle redirection for all old requests.

This PR also bumps the version of NodeJS we are using since v18 is no longer supported on App Engine

Copy link
Member

@meadowsys meadowsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a quick check, but this seems okay to me,

might be good to add some tests for this redirect also?

@savetheclocktower
Copy link
Contributor

Likewise, I wouldn't mind a test if you had a testing method in mind. Failing that, you could land this when some of us are around, have us all try to break it, then revert it if we find a crucial flaw.

@confused-Techie
Copy link
Member Author

confused-Techie commented Sep 1, 2025

Unfortunately, the tests in the repository are essentially non existent as bad as that is. But additionally, even if we had tests I am not immediately sure of how to test redirection of a domain when tests locally would be using localhost as the domain.

Maybe in the future we could attempt to do some type of DNS overrides in the test box, but failing that I'm not sure how we could go about testing it.

How do we feel about deploying now testing in prod, and if everything fails it's super easy in the GCP dashboard to revert the version. We can coordinate on Discord to ensure we have a couple people around to test this behavior out


EDIT:
But seeing as how this change is no way a time sensitive one, I'd be perfectly willing to first go to the drawing board for tests and come back to this when we are ready. So if we feel more comfortable with that I'm all for it

@savetheclocktower
Copy link
Contributor

Works for me.

@confused-Techie confused-Techie merged commit e5cff56 into main Sep 2, 2025
2 checks passed
@confused-Techie confused-Techie deleted the web-redirect branch September 2, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants