Redirect all web traffic to packages#141
Conversation
meadowsys
left a comment
There was a problem hiding this comment.
only a quick check, but this seems okay to me,
might be good to add some tests for this redirect also?
|
Likewise, I wouldn't mind a test if you had a testing method in mind. Failing that, you could land this when some of us are around, have us all try to break it, then revert it if we find a crucial flaw. |
|
Unfortunately, the tests in the repository are essentially non existent as bad as that is. But additionally, even if we had tests I am not immediately sure of how to test redirection of a domain when tests locally would be using Maybe in the future we could attempt to do some type of DNS overrides in the test box, but failing that I'm not sure how we could go about testing it. How do we feel about deploying now testing in prod, and if everything fails it's super easy in the GCP dashboard to revert the version. We can coordinate on Discord to ensure we have a couple people around to test this behavior out EDIT: |
|
Works for me. |
With us launching the new subdomain for packages, and those changes being live we now just need to handle redirection for all old requests.
This PR also bumps the version of NodeJS we are using since v18 is no longer supported on App Engine