Merged
Conversation
Member
Author
|
Gonna go ahead and merge this one as it's just to a feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
v2endpoint version, as well as enables handling of multiple different endpoint versions when building endpoints.The intention of this new declaration format is to enable easier to build endpoints, simpler declarations, and of course closing the gap between intended behavior and actual behavior on the endpoint.
You may notice that this idea is a re-implementation of #293 as I've had time to think about that PR and find other ways to improve upon it.
My example for testing this functionality is again by adding support for the
Server-Timingspecification to a single endpoint (/api/owners/:ownerName).Since this capability very much shows how closely linked we can make the endpoint main logic, the instantiated context, and the end HTTP result.
Better than my previous version I've added some documentation to help explain the differences, and properly define them.
The modification to the endpoint builder means we can upgrade this new behavior per endpoint as needed without breaking the rest of the codebase or requiring huge updates across the board like we've had to in the past.
The intention of this PR is to build towards #297 as I've been doing elsewhere