Skip to content

Conversation

@savetheclocktower
Copy link

Fixes #8.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

From testing, I can confirm the problem exists as described in #8, and I can confirm this change fixes the issue in question. 👍

Testing notes:

  • I set up a Fedora 43 LiveUSB environment
    • (Coincidentally already had this set up before I saw this PR!)
  • Tried yarn install in a checkout of pulsar-edit/pulsar
    • (Installed various X11 and Wayland-related -devel packages until their respective "missing header" compilation errors went away (typical when starting from a fresh LiveUSB environment without all these development header packages, unrelated to the present issue/PR)
    • Confirmed compilation error as described in #8 👍
  • Modified pulsar-edit/pulsar's package.json where it specifies @pulsar-edit/fuzzy-native, with a new "version specifier" to test this PR's changes, like so:
    • "@pulsar-edit/fuzzy-native": "https://github.com/pulsar-edit/fuzzy-native/archive/368c8c7b179482f1958ca44e2bcfd8d43e302ab1.tar.gz",
  • Did yarn install again
    • This worked, yarn install completed without errors! 👍

@DeeDeeG DeeDeeG merged commit 839e83a into master Jan 4, 2026
1 check passed
@DeeDeeG
Copy link
Member

DeeDeeG commented Jan 4, 2026

Thank you @savetheclocktower for giving this fix, and to @leotada for the initial report!

We can get it into core Pulsar by tagging a new version of this package, and bumping that in core Pulsar repo.

@savetheclocktower
Copy link
Author

savetheclocktower commented Jan 4, 2026

The bad news is that I think we have to revisit the CI workflow that publishes to NPM (since NPM has made those publishing-related changes for security). The good news is that this is probably just a nice-to-have and not a blocker for the Electron upgrade release.

@savetheclocktower savetheclocktower deleted the explicit-cstdint branch January 4, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to build on Fedora 43

3 participants