-
Notifications
You must be signed in to change notification settings - Fork 47
Add initial support for domains #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d173eb to
d7e86c1
Compare
CHANGES/domain-enablement.feature
Outdated
| Add partial support for Domains. The plugin can be installed with the feature turned on, but only | ||
| the default domain will properly work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would much prefer if we can say "it only functions in the default domain". By that i mean, that you could not create a container repository outside of the default domain for example.
5904d07 to
257de4e
Compare
|
I saw that in some places we are creating the objects with the domain definition, but in others we are not (which is fine, since it will use the default domain).
pulp_container/pulp_container/app/tasks/sync_stages.py Lines 394 to 402 in 257de4e
pulp_container/pulp_container/app/tasks/sync_stages.py Lines 416 to 424 in 257de4e
pulp_container/pulp_container/app/tasks/sync_stages.py Lines 436 to 446 in 257de4e
pulp_container/pulp_container/app/tasks/sync_stages.py Lines 503 to 504 in 257de4e
|
|
I think this also can be a problem in the future (in case FileContent is not at the same domain as the request), right?
|
git-hyagi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this awesome PR!
It looks good to me! I left some comments, but they can be considered more like questions or notes than "suggestions of change".
75552a4 to
880d141
Compare
This doesn't fully add support for domains. It just allows us to turn on the feature with pulp-container installed. I'm splitting up the work, thanks to @mdellweg suggestion, in order to make it easier to review and merge.