feat: add gunicorn_access_logformat field to Api and Content specs

[yaker-gh]

Summary

Adds a new CRD field gunicorn_access_logformat to customize gunicorn's access log format for api and content pods.

Closes #1564

Changes

pulp_types.go

• Add GunicornAccessLogformat field to Api struct
• Add GunicornAccessLogformat field to Content struct

deployment.go

• Modify setEnvVars(): Set PULP_GUNICORN_ACCESS_LOGFORMAT env var with default value if field is empty
• Modify pulpcoreApiContainerArgs(): Remove hardcoded --access-logformat from gunicorn ENTRYPOINT array, add --access-logformat "${PULP_GUNICORN_ACCESS_LOGFORMAT}" to exec command
• Modify pulpcoreContentContainerArgs(): Add --access-logformat "${PULP_GUNICORN_ACCESS_LOGFORMAT}" to exec command

controller_test.go

• Add PULP_GUNICORN_ACCESS_LOGFORMAT to envVarsApi and envVarsContent
• Update apiContainers and content container Args to match new shell script behavior

Default format:

pulp [%({correlation-id}o)s]: %(h)s %(l)s %(u)s %(t)s "%(r)s" %(s)s %(b)s "%(f)s" "%(a)s"

This preserves existing behavior when the field is not specified - the default includes the correlation-id header from django_guid.

Usage

spec:
  api:
    gunicorn_access_logformat: '{"remote_ip": "%(h)s", "method": "%(m)s", "path": "%(U)s", "status": "%(s)s"}'
  content:
    gunicorn_access_logformat: '{"remote_ip": "%(h)s", "method": "%(m)s", "path": "%(U)s", "status": "%(s)s"}'

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yaker-gh
Once this PR has been reviewed and has the lgtm label, please assign ipanova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @yaker-gh. Thanks for your PR.

I'm waiting for a pulp member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[balasankarc]

@git-hyagi I am not entirely sure why the CI is failing. 🤔 Do you have any idea?

[git-hyagi]

Hi @balasankarc!

hmm... in this PR we are trying to define the same default log format for API and content pods, but they use different gunicorn worker classes (which accept different log formats).
For the content pods, we run the aiohttp.GunicornWebWorker. It does not seem to be happy with the format we passed and is crashing:

Error: -30T20:24:29.407798056Z [2025-12-30 20:24:29 +0000] [529] [ERROR] Exception in gunicorn worker
 Traceback (most recent call last):
   File "/usr/local/lib64/python3.11/site-packages/aiohttp/worker.py", line 63, in run
     self.loop.run_until_complete(self._task)
   File "/usr/lib64/python3.11/asyncio/base_events.py", line 654, in run_until_complete
     return future.result()
            ^^^^^^^^^^^^^^^
   File "/usr/local/lib64/python3.11/site-packages/aiohttp/worker.py", line 97, in _run
     access_log_format=self._get_valid_log_format(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib64/python3.11/site-packages/aiohttp/worker.py", line 231, in _get_valid_log_format
     raise ValueError(
 ValueError: Gunicorn's style options in form of `%(name)s` are not supported for the log formatting.

What if we define the aiohttp's default log format for the content pods?
https://docs.aiohttp.org/en/stable/logging.html#format-specification

'%a %t "%r" %s %b "%{Referer}i" "%{User-Agent}i"'

[balasankarc]

Hi @balasankarc!

hmm... in this PR we are trying to define the same default log format for API and content pods, but they use different gunicorn worker classes (which accept different log formats). For the content pods, we run the aiohttp.GunicornWebWorker. It does not seem to be happy with the format we passed and is crashing:

Error: -30T20:24:29.407798056Z [2025-12-30 20:24:29 +0000] [529] [ERROR] Exception in gunicorn worker
 Traceback (most recent call last):
   File "/usr/local/lib64/python3.11/site-packages/aiohttp/worker.py", line 63, in run
     self.loop.run_until_complete(self._task)
   File "/usr/lib64/python3.11/asyncio/base_events.py", line 654, in run_until_complete
     return future.result()
            ^^^^^^^^^^^^^^^
   File "/usr/local/lib64/python3.11/site-packages/aiohttp/worker.py", line 97, in _run
     access_log_format=self._get_valid_log_format(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/local/lib64/python3.11/site-packages/aiohttp/worker.py", line 231, in _get_valid_log_format
     raise ValueError(
 ValueError: Gunicorn's style options in form of `%(name)s` are not supported for the log formatting.

What if we define the aiohttp's default log format for the content pods? https://docs.aiohttp.org/en/stable/logging.html#format-specification

'%a %t "%r" %s %b "%{Referer}i" "%{User-Agent}i"'

@git-hyagi Oops. I had figured that out (and commented above) after I pinged you. 😅 Sorry about the noise.