Skip to content

Conversation

@fischeti
Copy link
Collaborator

@fischeti fischeti commented Dec 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 4, 2025 14:24
@fischeti fischeti force-pushed the fix-rsvd-rdl-fields branch from d460c10 to 964266f Compare December 4, 2025 14:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors hardware register assignment code to use macros for improved maintainability and fixes a configuration-dependent module name reference. The changes introduce a new header file with register assignment macros and update the register interface code to use these macros instead of repetitive manual assignments.

Key changes:

  • Introduced rdl_assign.svh header with macros for register read/write acknowledgment assignments
  • Refactored register interface assignments in slink.sv to use the new macros and intermediate signals
  • Fixed module name from i_serial_link_network to i_serial_link_protocol in wave configuration

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/include/rdl_assign.svh New header file defining macros for RDL register read/write acknowledgment assignments
src/slink.sv Refactored register interface code to use new macros and intermediate signals; added include directive
Bender.yml Added include directory configuration for the new header file
util/wave.tcl Fixed module instance name from network to protocol layer
Comments suppressed due to low confidence (1)

src/include/rdl_assign.svh:15

  • The macro SLINK_SET_RDL_WR_ACK has incorrect logic. It's checking ~reg2hw.field.req_is_wr (NOT write request) but should check reg2hw.field.req_is_wr (IS write request) to match the write acknowledgment semantics. This is inconsistent with SLINK_ASSIGN_RDL_WR_ACK on line 9.
`define SLINK_SET_RDL_WR_ACK(field, hw2reg = hw2reg, reg2hw = reg2hw) \
  hw2reg.field.wr_ack = reg2hw.field.req & reg2hw.field.req_is_wr;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fischeti fischeti force-pushed the fix-rsvd-rdl-fields branch from 3015be2 to 291ec6f Compare December 8, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants