-
Notifications
You must be signed in to change notification settings - Fork 11
hw: Fix configuration dependent field names #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d460c10 to
964266f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors hardware register assignment code to use macros for improved maintainability and fixes a configuration-dependent module name reference. The changes introduce a new header file with register assignment macros and update the register interface code to use these macros instead of repetitive manual assignments.
Key changes:
- Introduced
rdl_assign.svhheader with macros for register read/write acknowledgment assignments - Refactored register interface assignments in
slink.svto use the new macros and intermediate signals - Fixed module name from
i_serial_link_networktoi_serial_link_protocolin wave configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/include/rdl_assign.svh | New header file defining macros for RDL register read/write acknowledgment assignments |
| src/slink.sv | Refactored register interface code to use new macros and intermediate signals; added include directive |
| Bender.yml | Added include directory configuration for the new header file |
| util/wave.tcl | Fixed module instance name from network to protocol layer |
Comments suppressed due to low confidence (1)
src/include/rdl_assign.svh:15
- The macro
SLINK_SET_RDL_WR_ACKhas incorrect logic. It's checking~reg2hw.field.req_is_wr(NOT write request) but should checkreg2hw.field.req_is_wr(IS write request) to match the write acknowledgment semantics. This is inconsistent withSLINK_ASSIGN_RDL_WR_ACKon line 9.
`define SLINK_SET_RDL_WR_ACK(field, hw2reg = hw2reg, reg2hw = reg2hw) \
hw2reg.field.wr_ack = reg2hw.field.req & reg2hw.field.req_is_wr;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3015be2 to
291ec6f
Compare
No description provided.