Skip to content

Conversation

@alex96295
Copy link
Contributor

@alex96295 alex96295 commented Feb 27, 2024

Should be possible to merge after #PR46 is merged

@alex96295 alex96295 requested a review from micprog February 27, 2024 09:48
@alex96295 alex96295 marked this pull request as ready for review March 7, 2024 08:49
@micprog
Copy link
Member

micprog commented Jun 17, 2024

Looking at pulp-platform/pulp-runtime#46, I'm not sure if the threadx inclusion aligns. It seems like one Makefile expects a $(PULPRT_HOME)/threadx, while the other expects/creates a $(SAFED_SW_DIR)/threadx, which is to my knowledge not the same directory. Is this the case, or am I misunderstanding?

@alex96295
Copy link
Contributor Author

Looking at pulp-platform/pulp-runtime#46, I'm not sure if the threadx inclusion aligns. It seems like one Makefile expects a $(PULPRT_HOME)/threadx, while the other expects/creates a $(SAFED_SW_DIR)/threadx, which is to my knowledge not the same directory. Is this the case, or am I misunderstanding?

True, I added the modifications in PULP runtime afterwards; will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants