Skip to content

rtl: Move wildcard imports to module header #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alex96295 wants to merge 1 commit into
base: astral-v1.0
Choose a base branch
from
Open

rtl: Move wildcard imports to module header #33

alex96295 wants to merge 1 commit into from

Conversation

@alex96295
Copy link

@alex96295 alex96295 commented Jun 2, 2025

Global wildcard imports may create name collision, as indicated in: https://github.com/lowRISC/style-guides/blob/master/VerilogCodingStyle.md#wildcard-import-of-packages

@alex96295 alex96295 requested a review from LuigiGhionda June 2, 2025 14:07
@alex96295
Copy link
Author

alex96295 commented Jun 2, 2025 •
edited
Loading

@LuigiGhionda opened a PR targeting astral-v1.0 because this is what we use in the pulp-cluster releases. I suggest we soon converge into main to avoid rebase etc; I pinpointed the same to @belanoa for softex: we should try to merge all the "astral/carfield-related" features in main and do normal semantic versioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LuigiGhionda LuigiGhionda Awaiting requested review from LuigiGhionda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex96295