Fix NEureka PEs grid configurations #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuigiGhionda
force-pushed
the
lg/pe_config
branch
from
79f74ae to
8920955
Compare
LuigiGhionda
changed the title
FrancescoConti
approved these changes
Apr 24, 2025
Member
FrancescoConti
left a comment
FrancescoConti
left a comment
There was a problem hiding this comment.
LGTM (but fix the CI!)
Only configurations covered by this script have been tested; others are unverified.
LuigiGhionda
force-pushed
the
lg/pe_config
branch
from
8920955 to
1b3bd6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes PE grid configurations beyond the default 4×4, including non-square layouts such as 4×2 and 2×4.
The changes primarily affect the control logic, ensuring the correct processing elements are enabled and that input activations are dispatched appropriately for any given grid shape.
The (H, W) configuration of the PE grid is now passed as a parameter from the Makefile to the testbench, and is also used in the software dependency to properly handle tiling (see here).
Originally made for NEureka-FT, it may be of general interest.