Open
Conversation
sagivo
requested changes
Feb 4, 2018
Member
sagivo
left a comment
sagivo
left a comment
There was a problem hiding this comment.
most are minor changes but the biggest change needed is streaming the upload/download of a file as we can't load all to memory
| projectId: 'blokk-12345' | ||
| }; | ||
|
|
||
| module.exports = googleConf; No newline at end of file |
| const blockTx = await ethereumeStore.set(namespace, req.body.key, ipfsHash); | ||
|
|
||
| // Google Storage | ||
| const {projectId} = require('./configs/googleConf'); |
Member
There was a problem hiding this comment.
can we move all this google init block to the google storage file?
|
|
||
| const put = async (googleStorage, namespace, key, value) => { | ||
| const filePath = getFilePath(namespace, key); | ||
| const tmp = require('tmp'); |
Member
There was a problem hiding this comment.
require should be on the top of a file
| const file = myBucket.file(filePath); | ||
| file.download(function (err, contents) { | ||
| if (err) reject(err); | ||
| resolve(contents); |
Member
There was a problem hiding this comment.
we want to work with streams as if it's a large file you don't want to download it all to memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.