Skip to content

Ref/example apps #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jspizziri wants to merge 9 commits into
base: rework
Choose a base branch
from
Open

Ref/example apps #4

jspizziri wants to merge 9 commits into from

Conversation

@jspizziri
Copy link

@jspizziri jspizziri commented Oct 21, 2025

No description provided.

@jspizziri jspizziri force-pushed the ref/example-apps branch 2 times, most recently from 0fed9b2 to ccaa4e8 Compare October 30, 2025 18:32
@jspizziri
Copy link
Author

jspizziri commented Oct 30, 2025 •
edited
Loading

@puckey, a few specific callouts about this PR I wanted to draw your attention to:

  1. I've fixed the broken lint config and run a style update based on the rules. One thing you might not be keen on is the way I'm handling type coercion in places like this
  2. I've reorganized web/TrackPlayerModule.ts to more closely mirror the organization of src/NativeTrackPlayer.ts.
  3. I left a FIXME comment here that I wanted to chat about with you

@jspizziri
Copy link
Author

jspizziri commented Nov 3, 2025

The Android build is failing due to references to the ControllerConnectedEvent/ControllerDisconnectedEvent inside of TrackPlayer.kt. Those classes were removed in this commit, but not all the references to them were cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jspizziri