Replace hardcoded DB defaults with values from default.config.toml#690
Open
ok300 wants to merge 10 commits intopubky:mainfrom
Open
Replace hardcoded DB defaults with values from default.config.toml#690ok300 wants to merge 10 commits intopubky:mainfrom
default.config.toml#690ok300 wants to merge 10 commits intopubky:mainfrom
Conversation
ok300
force-pushed
the
copilot/update-db-config-to-deserialize-toml
branch
from
e742e50 to
20910e0
Compare
tipogi
added
the
🧬 Database
ok300
force-pushed
the
copilot/update-db-config-to-deserialize-toml
branch
from
914733b to
839d731
Compare
ok300
force-pushed
the
copilot/update-db-config-to-deserialize-toml
branch
from
fa0c61e to
fdcbd75
Compare
|
|
||
| // Create temporal struct to wrap database config | ||
| fn default_neo4j_user() -> String { | ||
| String::from("neo4j") |
Contributor
There was a problem hiding this comment.
Should this constant be removed as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces hardcoded DB params with those read and parsed from
default.config.toml.This was expanded to include
StackConfigand its fields, some of which were also hardcoded (log level,FILES_DIR) but for whichdefault.config.tomlalready defined the same defaults.