WIP: Upsampling/Downsampling kernels #305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
bjoernenders
requested changes
Apr 9, 2021
Contributor
bjoernenders
left a comment
bjoernenders
left a comment
There was a problem hiding this comment.
See that one comment. Otherwise go ahead.
| if kern.resample: | ||
| aux_tmp1 = np.abs(aux)**2 | ||
| au.resample(aux_tmp2, aux_tmp1) | ||
| au.resample(aux_tmp1, aux_tmp2) |
Contributor
There was a problem hiding this comment.
this looks odd. Shouldn't the second resample be after make model?
daurer
force-pushed
the
gpu-hackathon-upsampling
branch
from
222e0a1 to
556d111
Compare
8 tasks
daurer
force-pushed
the
gpu-hackathon-upsampling
branch
from
b375d7a to
3f756b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.