Closed
Conversation
Add a promotion filter for what promotions to consider when enumerating moves. bench: 729284
This will replace the function that returns a massive tuple of data for legal move gen. bench: 729284
Integrate submodule and updated enumerate moves function into main movegen and legal movegen. bench: 729284
bench: 729284
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 94.63% 94.57% -0.06%
==========================================
Files 45 46 +1
Lines 7896 7927 +31
==========================================
+ Hits 7472 7497 +25
- Misses 424 430 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The new approach had significantly worse performance (~13% worse) in search bench. This simplifies our approach to just provide a move type (all, capture, quiet) when generating moves and then the mobility bitboards are just &'d with a mask. This makes the new move gen only ~3% worse on average compared to main. bench: 773383
We changed the function signature so we have to update all the call sites. bench: 773383
bench: 773383
bench: 773383
bench: 773383
bench: 773383
ptsouchlos
force-pushed
the
feature/staged-legal-movegen
branch
from
e7aa992 to
d345340
Compare
Owner
Author
|
Closing in favor of #273 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactor
move_generation,legal_move_generationand submodules for staged legal movegen. This is a stepping stone for implementing a move picker (#41).bench: 729284